Modify __init__ for sse_client when using thirdparty import#484
Closed
ChenJiahaoST wants to merge 3 commits into
Closed
Modify __init__ for sse_client when using thirdparty import#484ChenJiahaoST wants to merge 3 commits into
ChenJiahaoST wants to merge 3 commits into
Conversation
![mcp-shadow[bot]](https://avatars.githubusercontent.com/in/1260490?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for your pull request to improve the import experience for the SSE client in the MCP Python SDK. I appreciate your effort to align the SSE client import with the stdio_client pattern.
However, I must reject this PR for the following reasons:
-
The streamable HTTP transport has superseded SSE in the latest MCP specification. Adding this import would encourage continued use of a deprecated transport method.
-
Adding top-level imports increases our maintenance burden, as we need to maintain backward compatibility for any public API surfaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sse_client import in top init.py file.
Motivation and Context
When using mcp by lazy import in some Agent dev tools, cannot using sse_client as easily as stdio_client (mcp.client.sse.sse_client V.S. mcp.stdio_client), which is very uncomfortable and sometime may cause importing error.
After adding this change, user can import sse_client like stdio_client.
How Has This Been Tested?
I have tested this using a open source framework called LazyLLM, after adding this change, bug wiil be fixed.
Breaking Changes
No need to update, user can also use
from mcp import sse_client, stdio_clientrather than
Types of changes
Checklist
Additional context